Skip to content

Cupertino localization step 12 try 2: push translation for all supported languages - #32513

Merged
xster merged 3 commits into
flutter:masterfrom
xster:push2
May 19, 2019
Merged

xster merged 3 commits into
flutter:masterfrom
xster:push2

Conversation

@xster

@xster xster commented May 10, 2019 •

Copy link
Copy Markdown
Member

More or less the same as #31644 but some of the date format related strings were wrong

Fixes #13452

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selectAllButtonLabel should be exactly as the iOS SO because it overrides it. In this language the System uses Upper Case only in the first word.

Suggested change
"selectAllButtonLabel": "Selecionar Tudo"
"selectAllButtonLabel": "Selecionar tudo"

@Piinks Piinks added a: internationalization Supporting other languages or locales. (aka i18n) p: cupertino_ui cupertino_ui package in flutter/packages labels May 16, 2019

@vincevargadev vincevargadev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The German translations don't match exactly. I recommended some changes and posted some screenshots to show how the material labels differ from the cupertino labels.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"pasteButtonLabel": "Einfügen",
"pasteButtonLabel": "Einsetzen",

iOS-DE-Einsetzen

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the default podcast app to check the German "paste" label for iOS

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"postMeridiemAbbreviation": "NACHM.",
"postMeridiemAbbreviation": "PM",

See
iOS-DE-AMPM-example-1
Uploading iOS-DE-AMPM-example-2.PNG…

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"anteMeridiemAbbreviation": "VORM.",
"anteMeridiemAbbreviation": "AM",

@xster

xster commented May 16, 2019

Copy link
Copy Markdown
Member Author

Thanks for your feedbacks, they are migrated back into the translation console.

@HansMuller HansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@xster

xster commented May 17, 2019

Copy link
Copy Markdown
Member Author

@fkorotkov can you help us take a look? It seems like the windows bots are having some issues

@fkorotkov

Copy link
Copy Markdown
Contributor

@xster Sorry, just noticed the GitHub notification. It should be working now. Sorry for the inconvenience! Don't hesitate to ping [email protected] next time for quicker response.

@xster
xster merged commit 51799d3 into flutter:master May 19, 2019
@xster
xster deleted the push2 branch May 19, 2019 11:10
HansMuller referenced this pull request in flutter/website Feb 25, 2020
Added cupertino localizations in order to not run into flutter/flutter#13452
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: internationalization Supporting other languages or locales. (aka i18n) p: cupertino_ui cupertino_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need Cupertino Translations

7 participants