Repository navigation
Change the way macOS app names are located - #32706
Merged
stuartmorgan-g merged 4 commits intoMay 16, 2019
Merged
Conversation
Instead of requiring a name_output.sh, expect a file called .app_filename in the macos/Flutter directory containing just the name of the application. The expectation is that the Xcode build will create that file with a script. This is not intended as a long-term solution, but it's a substantial improvement over name_output.sh: - name_output.sh required constructing the full build output path; this made sense when it was coupled with build.sh, but now that the decision for where build output goes lives in flutter_tool, that logic should as well. - Changing the name of the application required also updating name_output.sh, which is error-prone. With .app_filename, it can be created using $PRODUCT_NAME, which means that the usual way of setting the application name will automatically update this flow as well. Related to flutter#30706
stuartmorgan-g
commented
May 14, 2019
|
|
||
| // Ensure that the executable is locatable. | ||
| final String executable = package.executable(debuggingOptions?.buildInfo?.mode); | ||
| if (executable == null) { |
Contributor
Author
There was a problem hiding this comment.
Added this check so that the tool exits gracefully, rather than crashing, if the name of the executable couldn't be determined.
stuartmorgan-g
added a commit
to stuartmorgan-g/flutter-desktop-embedding
that referenced
this pull request
May 14, 2019
stuartmorgan-g
added a commit
to google/flutter-desktop-embedding
that referenced
this pull request
May 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of requiring a name_output.sh, expect a file called
.app_filename in the macos/Flutter directory containing just the name of
the application. The expectation is that the Xcode build will create
that file with a script.
This is not intended as a long-term solution, but it's a substantial
improvement over name_output.sh:
made sense when it was coupled with build.sh, but now that the
decision for where build output goes lives in flutter_tool, that logic
should as well.
name_output.sh, which is error-prone. With .app_filename, it can be
created using $PRODUCT_NAME, which means that the usual way of setting
the application name will automatically update this flow as well.
Related Issues
#30706
Tests
I added the following tests: None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?
This is a breaking change for the desktop workflow, but it is explicitly volatile at this stage.