Repository navigation
ModalRoute resumes previous focus on didPopNext - #33152
Merged
Merged
Conversation
muttalipkucuk
approved these changes
May 22, 2019
goderbauer
added
the
framework
Piinks
reviewed
May 23, 2019
Member
|
@gspencergoog Can you take a look at this since you recently worked with the focus sub-system? |
Contributor
|
This change was identified as causing tests to fail inside Google. Since other teams are blocked on the roll, we'll have to investigate tomorrow what the underlying cause is (it's possible that the test is doing something wrong, or it's possible there's a bug in this PR). For now, I'm going to revert to unblock the roll. |
tvolkert
added a commit
that referenced
this pull request
Jun 4, 2019
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
ModalRouteso that, when the route on top of it is popped, it requests to focus on the last focus.Currently when the user is editing something, the edit will be interrupted by popups or dialogs. After this PR, the edit will be resumed after the popup or dialog is closed. See the following example:
Before:
After:
Related Issues
None
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?