Repository navigation
Add capability to flutter test --platform=chrome - #33525
Merged
jonahwilliams merged 8 commits intoMay 31, 2019
Merged
Conversation
goderbauer
added
the
tool
blasten
reviewed
May 31, 2019
blasten
reviewed
May 31, 2019
blasten
self-requested a review
May 31, 2019 19:31
yjbanov
approved these changes
May 31, 2019
| @@ -1,5 +1,8 @@ | |||
| targets: | |||
| $default: | |||
| builders: | |||
Contributor
There was a problem hiding this comment.
Why do these need to be explicitly disabled? flutter_tools don't have any web code afaict.
Contributor
Author
There was a problem hiding this comment.
Because we use build_runner for running tests and build_runner scans the pubspec for dependencies to determine which targets to build. Since we now depend on build_web_compilers, it tries to initialize a bunch of web builders for the test script. This hasn't fully stopped the errors, I suspect we need to disable more builders.
Contributor
|
FYI @jonahwilliams |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows running flutter tests compiled to JavaScript served through a chrome instance. Requires engine and framework changes to actually run tests.
Related Issues
#33349