Skip to content

Kill compiler process when test does not exit cleanly - #34616

Merged
jmagman merged 1 commit into
flutter:masterfrom
jmagman:kill
Jun 18, 2019
Merged

jmagman merged 1 commit into
flutter:masterfrom
jmagman:kill

Conversation

@jmagman

@jmagman jmagman commented Jun 18, 2019

Copy link
Copy Markdown
Member

Description

Disposing of the test_compiler should also kill the underlying compiler process.

Related Issues

Fixes #34613.

Tests

Confirmed repro steps in #34613 no longer leaks process.
I added the following tests:

  • New test_compiler_test test.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@jmagman jmagman added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 18, 2019
@jmagman
jmagman requested a review from jonahwilliams June 18, 2019 00:12

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
jmagman merged commit 8be46a0 into flutter:master Jun 18, 2019
@jmagman
jmagman deleted the kill branch June 18, 2019 21:56
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flutter test leaks frontend_server.dart.snapshot on exception

3 participants