Repository navigation
Added demo projects for splash screen support on Android. - #35728
Conversation
goderbauer
added
a: existing-apps
|
Looks like the analyzer is unhappy: https://cirrus-ci.com/task/6536306685902848 |
36e0421 to
2263464
Compare
|
@xster @dnfield would one or both of you mind reviewing this PR? This PR adds 2 manual projects for future verification, as well as a "kitchen sink" project that is hooked up to the device lab. I ran the device lab test locally and it passes. The PR that contains the code being exercised in these projects is here: That other PR already has an LGTM - it's just waiting for tests to be approved. |
|
|
||
| ## Running tests against a local engine build | ||
|
|
||
| To run device lab tests against a local engine build, pass the appropriate |
| description: > | ||
| Runs end-to-end test of Flutter's Android splash behavior. | ||
| stage: devicelab | ||
| required_agent_capabilities: ["mac/android"] |
There was a problem hiding this comment.
I didn't really know what I was doing here...I just copied another test. It seems like there is some pattern to running certain things only on mac. Any idea what the right answer is? CC @dnfield
There was a problem hiding this comment.
We have two linux/android and I believe two mac/android device - but the linux/android tend to be more stable. Probably better to go with linux/android for this and reserve the mac capacity for what really requires mac.
There was a problem hiding this comment.
Will do. Thanks.
|
@xster I ran optipng on the pngs but git isn't showing any diff to commit. Do you know what I need to do to update those in git? |
015acdb to
f2a534a
Compare
|
Chatted offline. We're not sure why optipng doesn't show changes in git, but we'll leave the PNGs as-is for now. |
|
Everything is green. I'm gonna merge these in. |
| description: > | ||
| Runs end-to-end test of Flutter's Android splash behavior. | ||
| stage: devicelab | ||
| required_agent_capabilities: ["linux/android"] |
There was a problem hiding this comment.
Tests should be marked flaky when newly added, until they have been proved for a few cycles. (See documentation at the top of the manifest.)
|
Looks like the new devicelab test is failing. |
6 participants
Added demo projects for splash screen support on Android.
These projects intended both as a demo for app devs to see what is possible, as well as ready built debugging projects for Flutter team devs that need to work on splash support on Android.
Note: Do not merge until the associated engine work has merged:
flutter-team-archive/engine#9525