Skip to content

Revert "Part 1: Skia Gold Testing" - #36094

Merged
Piinks merged 1 commit into
masterfrom
revert-33688-goldIntegration
Jul 12, 2019
Merged

Piinks merged 1 commit into
masterfrom
revert-33688-goldIntegration

Conversation

@Piinks

@Piinks Piinks commented Jul 12, 2019

Copy link
Copy Markdown
Contributor

Reverts #33688

Tests appear to be failing in post-submit due to the encrypted service account key returning null.

@fluttergithubbot fluttergithubbot added p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jul 12, 2019

@GaryQian GaryQian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Piinks
Piinks merged commit 8809f69 into master Jul 12, 2019
@dnfield
dnfield deleted the revert-33688-goldIntegration branch July 16, 2019 16:04
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
This reverts commit eb0b179.
Skia Gold post-submit test were failing due to the service account not being found on Cirrus.
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants