Skip to content

Revert "Fix semantics for floating pinned sliver app bar" - #36319

Merged
dnfield merged 1 commit into
masterfrom
revert-35574-fix_scrolling_app_bar_semantics
Jul 17, 2019
Merged

dnfield merged 1 commit into
masterfrom
revert-35574-fix_scrolling_app_bar_semantics

Conversation

@dnfield

@dnfield dnfield commented Jul 16, 2019

Copy link
Copy Markdown
Contributor

Reverts #35574

This broke some internal tests. Need to figure out why.

@dnfield
dnfield requested a review from gspencergoog July 16, 2019 23:52
@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 16, 2019

@gspencergoog gspencergoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@dnfield
dnfield merged commit 5923f34 into master Jul 17, 2019
@dnfield
dnfield deleted the revert-35574-fix_scrolling_app_bar_semantics branch July 17, 2019 16:24
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants