Skip to content

Ability to extend scaffold body behind the appBar. - #39093

Closed
domesticmouse wants to merge 5 commits into
flutter:masterfrom
domesticmouse:master
Closed

Ability to extend scaffold body behind the appBar.#39093
domesticmouse wants to merge 5 commits into
flutter:masterfrom
domesticmouse:master

Conversation

@domesticmouse

@domesticmouse domesticmouse commented Aug 23, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Implementing the capability to extend the Scaffold's body up behind the appBar.

Related Issues

Fixes: #17088

Tests

Added a test to Scaffold for "body size with extendBody and extendBehindAppBar".

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Aug 23, 2019
@fluttergithubbot

fluttergithubbot commented Aug 23, 2019

Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@HansMuller

HansMuller commented Aug 24, 2019

Copy link
Copy Markdown
Contributor

I'm afraid we've collided! I had written a PR to add the same feature over the last couple of days and I didn't see this one until just now. Sorry about that.

I've added you as a co-author on #39156 and would certainly welcome your review, if you're interested.

Again: sorry about the collision. It seems like we've happened to choose the exact same year-old issue at the same time.

@domesticmouse

domesticmouse commented Aug 24, 2019

Copy link
Copy Markdown
Contributor Author

Thanks Hans, it's a great learning experience to attempt to build the feature, then see how you do it. There are more moving parts than i was aware of =)

@HansMuller HansMuller mentioned this pull request Aug 26, 2019
Merged
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@willlarche willlarche Awaiting requested review from willlarche
@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Getting the body behind transparent Appbar

4 participants

@domesticmouse @fluttergithubbot @HansMuller @googlebot