Repository navigation
Added Scaffold.extendBodyBehindAppBar - #39156
Conversation
fluttergithubbot
added
p: material_ui
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
Co-author should be [email protected] =) |
|
I didn't realize that despite being over there, you're from here :-). Will fix up the co-authorage. |
46161ad to
bbeb5f7
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
| const _BodyBuilder({ Key key, this.body }) : super(key: key); | ||
| const _BodyBuilder({ | ||
| Key key, | ||
| @required this.extendBody, |
There was a problem hiding this comment.
With both extendBody and extendBodyBehindAppBar it is a little confusing. Is one is a subset of the other. Perhaps rename extendBody to something like extendBodyBottom to better describe that it is only extending the body on the bottom.
There was a problem hiding this comment.
I did lament the naming (the evolution of this API) in #17088 (comment)
As you noted below, it's preferable to leave extendBody alone.
| /// | ||
| /// * [extendBodyBehindAppBar], which extends the height of the body | ||
| /// to the top of the scaffold. | ||
| final bool extendBody; |
There was a problem hiding this comment.
Changing the name would mean breaking the API. Nevermind :).
|
What do I have to do to use this in my project? |
check to dev channel |
|
How can I figure which release this was in, or will be in? |
|
The current stable version is
Hope it will not take too long. |
|
1.12 stable has released with this feature. |
9 participants
Add support for extending the height of the Scaffold's body behind the app bar, to the top of the Scaffold. This is useful when the scaffold's AppBar has a translucent backgroundColor.
Fixes: #17088
A similar PR that addressed the same issue was created by @domesticmouse at about the same time as this one: #39093. I wanted to thank Brett Morgan for rolling with this tragic bit of synchronicity and for reviewing this PR!
Here's a small demo of the feature: