Repository navigation
[flutter_tool] Kill a timing-out process before trying to drain its streams - #40159
Merged
Merged
Conversation
zanderso
added
the
tool
Codecov Report
@@ Coverage Diff @@
## master #40159 +/- ##
==========================================
- Coverage 58.51% 58.06% -0.46%
==========================================
Files 192 192
Lines 18426 18416 -10
==========================================
- Hits 10782 10693 -89
- Misses 7644 7723 +79
Continue to review full report at Codecov.
|
…tdout/err streams
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
…tdout/err streams (flutter#40159)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a test of subprocess timeout behavior such that its stdout and stderr streams won't be completed until the subprocess is killed. The corrected test required that
runAsync()be fixed to kill a subprocess before trying to drain its output streams. I also maderunAsync()only try to drain the output streams of a killed process for a second or so to handle the case where the attempt to kill the subprocess is unsuccessful for some reason.Related Issues
#35988
Tests
I added the following tests:
Updates to process_test.dart
Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?