Skip to content

Revert "build bundle with assemble" - #40204

Merged
jonahwilliams merged 1 commit into
masterfrom
revert-37508-bundle_assemble
Sep 11, 2019
Merged

jonahwilliams merged 1 commit into
masterfrom
revert-37508-bundle_assemble

Conversation

@jonahwilliams

@jonahwilliams jonahwilliams commented Sep 11, 2019 •

Copy link
Copy Markdown
Contributor

Reverts #37508 TBR @zanderso

This broke two windows devicelab tests with "invalid path for file". I assumed that the gradle windows tests were completely exercising the file paths but it seems that wasn't the case. Will do more experimentation on a windows box.

@fluttergithubbot fluttergithubbot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Sep 11, 2019
@jonahwilliams
jonahwilliams merged commit 609a78f into master Sep 11, 2019
@jonahwilliams
jonahwilliams deleted the revert-37508-bundle_assemble branch September 11, 2019 03:04
@zanderso

Copy link
Copy Markdown
Member

lgtm

For posterity, please include the reason for the revert in the PR description.

@jonahwilliams

Copy link
Copy Markdown
Contributor Author

Done

Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants