Skip to content

[flutter_tool] Remove the synchronous -showBuildSettings - #40435

Merged
zanderso merged 1 commit into
flutter:masterfrom
zanderso:show-build-settings-async
Sep 16, 2019
Merged

[flutter_tool] Remove the synchronous -showBuildSettings#40435
zanderso merged 1 commit into
flutter:masterfrom
zanderso:show-build-settings-async

Conversation

@zanderso

@zanderso zanderso commented Sep 13, 2019

Copy link
Copy Markdown
Member

Description

Make the synchronous -showBuildSettings call asynchronous so that it can be run with a timeout/retry.

Related Issues

#35988

Tests

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@zanderso zanderso added tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Sep 13, 2019
jonahwilliams
jonahwilliams approved these changes Sep 13, 2019
View reviewed changes

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Sep 13, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #40435 into master will increase coverage by 0.91%.
The diff coverage is 88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #40435      +/-   ##
==========================================
+ Coverage   58.57%   59.49%   +0.91%     
==========================================
  Files         192      191       -1     
  Lines       18695    18586     -109     
==========================================
+ Hits        10950    11057     +107     
+ Misses       7745     7529     -216
Flag Coverage Δ
#flutter_tool 59.49% <88%> (+0.91%) ⬆️
Impacted Files Coverage Δ
...es/flutter_tools/lib/src/macos/cocoapod_utils.dart 25% <0%> (ø) ⬆️
...ckages/flutter_tools/lib/src/ios/code_signing.dart 93.15% <100%> (ø) ⬆️
packages/flutter_tools/lib/src/ios/xcodeproj.dart 88.75% <100%> (+0.62%) ⬆️
...ackages/flutter_tools/lib/src/commands/create.dart 72.69% <100%> (ø) ⬆️
...ackages/flutter_tools/lib/src/macos/cocoapods.dart 86.23% <100%> (ø) ⬆️
packages/flutter_tools/lib/src/commands/run.dart 64.56% <100%> (+0.48%) ⬆️
...ges/flutter_tools/lib/src/application_package.dart 67.15% <87.5%> (+16.41%) ⬆️
packages/flutter_tools/lib/src/project.dart 83.8% <90.9%> (+1.58%) ⬆️
...ges/flutter_tools/lib/src/build_system/source.dart 63.51% <0%> (-22.98%) ⬇️
...ools/lib/src/build_runner/resident_web_runner.dart 75.83% <0%> (-2.69%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3515d...9793b41. Read the comment docs.

@zanderso
zanderso merged commit 8a33d24 into flutter:master Sep 16, 2019
@zanderso
zanderso deleted the show-build-settings-async branch September 16, 2019 14:51
@zanderso zanderso mentioned this pull request Sep 16, 2019
Closed
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@zanderso @Inconnu08
[flutter_tool] Remove the synchronous -showBuildSettings (flutter#40435)
e9ae218
@aporquez aporquez mentioned this pull request Jan 22, 2020
Closed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jmagman jmagman Awaiting requested review from jmagman
@christopherfujino christopherfujino Awaiting requested review from christopherfujino
1 more reviewer
@jonahwilliams jonahwilliams jonahwilliams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zanderso @jonahwilliams @googlebot