Skip to content

Update minimum version to Xcode 10.2 - #42254

Merged
jmagman merged 1 commit into
flutter:masterfrom
jmagman:update-xcode
Oct 14, 2019
Merged

Update minimum version to Xcode 10.2#42254
jmagman merged 1 commit into
flutter:masterfrom
jmagman:update-xcode

Conversation

@jmagman

@jmagman jmagman commented Oct 8, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Description

  • Update Cirrus image version
  • Increase minimum required Xcode version to 10.2.

Related Issues

Fixes #41231.

Tests

Updated Xcode version tests.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 8, 2019
@jmagman jmagman mentioned this pull request Oct 8, 2019
Merged
8 of 9 tasks
@jmagman

jmagman commented Oct 8, 2019

Copy link
Copy Markdown
Member Author

Blocked by #39921.

@jmagman
jmagman marked this pull request as ready for review October 8, 2019 19:27
@codecov

codecov Bot commented Oct 8, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #42254 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #42254      +/-   ##
==========================================
- Coverage   59.98%   59.73%   -0.26%     
==========================================
  Files         194      194              
  Lines       18981    18979       -2     
==========================================
- Hits        11386    11337      -49     
- Misses       7595     7642      +47
Flag Coverage Δ
#flutter_tool 59.73% <ø> (-0.26%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/macos/xcode.dart 61.66% <ø> (ø) ⬆️
...s/flutter_tools/lib/src/test/flutter_platform.dart 0.55% <0%> (-27.5%) ⬇️
packages/flutter_tools/lib/src/version.dart 91.9% <0%> (-1.43%) ⬇️
packages/flutter_tools/lib/src/cache.dart 45.96% <0%> (-0.68%) ⬇️
packages/flutter_tools/lib/src/vmservice.dart 41.4% <0%> (+0.16%) ⬆️
packages/flutter_tools/lib/src/device.dart 61.76% <0%> (+2.94%) ⬆️
packages/flutter_tools/lib/src/run_cold.dart 19.51% <0%> (+9.75%) ⬆️
packages/flutter_tools/lib/src/base/build.dart 74.38% <0%> (+14.87%) ⬆️
packages/flutter_tools/lib/src/web/web_device.dart 48.19% <0%> (+28.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c64b236...eefcb63. Read the comment docs.

@jmagman
jmagman requested a review from dnfield October 9, 2019 23:52
dnfield
dnfield approved these changes Oct 10, 2019
View reviewed changes

@dnfield dnfield left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@digiter

digiter commented Oct 12, 2019

Copy link
Copy Markdown
Contributor

Mac machines in devicelab are using Xcode 11.0 now, this is unblocked.

@jmagman
jmagman merged commit a62bb3d into flutter:master Oct 14, 2019
@jmagman
jmagman deleted the update-xcode branch October 14, 2019 19:45
@DanTup DanTup mentioned this pull request Oct 15, 2019
Closed
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@jmagman @Inconnu08
Update minimum version to Xcode 10.2 (flutter#42254)
6282042
@jmagman jmagman added the platform-ios iOS applications specifically label Aug 21, 2020
@DanTup DanTup mentioned this pull request Oct 2, 2020
Closed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@dnfield dnfield dnfield approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update required minimum Xcode version

5 participants

@jmagman @digiter @dnfield @googlebot @fluttergithubbot