Skip to content

implement build aot with assemble for Android target platforms - #43282

Merged
jonahwilliams merged 5 commits into
flutter:masterfrom
jonahwilliams:implement_aot_assemble
Oct 30, 2019
Merged

jonahwilliams merged 5 commits into
flutter:masterfrom
jonahwilliams:implement_aot_assemble

Conversation

@jonahwilliams

Copy link
Copy Markdown
Contributor

Description

Implement flutter build aot in terms of flutter assemble. This will make it easier to eventually refactor xcode_backend.sh and flutter.gradle.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 22, 2019
@jonahwilliams jonahwilliams changed the title implement build aot with assemble [WIP] implement build aot with assemble Oct 22, 2019
args "--target", targetPath
args "--output-dir", "${intermediateDir}"
args "--target-platform", "${targetPlatform}"
if (trackWidgetCreation) {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not supported, and is a no-op in build aot

@jonahwilliams jonahwilliams changed the title [WIP] implement build aot with assemble [WIP] implement build aot with assemble for Android target platfroms Oct 30, 2019
@jonahwilliams jonahwilliams changed the title [WIP] implement build aot with assemble for Android target platfroms implement build aot with assemble for Android target platforms Oct 30, 2019

@zanderso zanderso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blasten blasten left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonahwilliams
jonahwilliams merged commit 79bc6ca into flutter:master Oct 30, 2019
@jonahwilliams
jonahwilliams deleted the implement_aot_assemble branch October 30, 2019 22:23
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants