Skip to content

module_test also seems to be flaky on mac - #43375

Closed
Hixie wants to merge 1 commit into
flutter:masterfrom
Hixie:module_test
Closed

Hixie wants to merge 1 commit into
flutter:masterfrom
Hixie:module_test

Conversation

@Hixie

@Hixie Hixie commented Oct 23, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Oct 23, 2019
@fluttergithubbot

Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie

Hixie commented Oct 23, 2019

Copy link
Copy Markdown
Contributor Author

We keep seeing module_test time out on mac shards on Cirrus. module_test_ios was already disabled for flaking; could be related?

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie

Hixie commented Oct 23, 2019

Copy link
Copy Markdown
Contributor Author

I've merged this into #43379.

@Hixie Hixie closed this Oct 23, 2019
@Hixie
Hixie deleted the module_test branch October 23, 2019 21:54
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants