Skip to content

ENABLE_ANDROID_EMBEDDING_V2 isn't a general thing. - #43379

Merged
Hixie merged 1 commit into
flutter:masterfrom
Hixie:ENABLE_ANDROID_EMBEDDING_V2
Oct 24, 2019
Merged

Hixie merged 1 commit into
flutter:masterfrom
Hixie:ENABLE_ANDROID_EMBEDDING_V2

Conversation

@Hixie

@Hixie Hixie commented Oct 23, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@fluttergithubbot

Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Oct 23, 2019
@Hixie

Hixie commented Oct 23, 2019

Copy link
Copy Markdown
Contributor Author

This subsumes #43375 also.

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me

@Hixie
Hixie force-pushed the ENABLE_ANDROID_EMBEDDING_V2 branch from 3db3156 to c9ad84f Compare October 23, 2019 21:48
@Hixie
Hixie merged commit 45e9f65 into flutter:master Oct 24, 2019
@Hixie
Hixie deleted the ENABLE_ANDROID_EMBEDDING_V2 branch October 24, 2019 00:22
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants