Skip to content

Revert "[Chip] Make sure InkResponse is in the foreground on delete f… - #43391

Merged
jonahwilliams merged 1 commit into
masterfrom
revert-41463-fix_material_chip_bug
Oct 24, 2019
Merged

jonahwilliams merged 1 commit into
masterfrom
revert-41463-fix_material_chip_bug

Conversation

@jonahwilliams

Copy link
Copy Markdown
Contributor

Failures:

03:43 +2170 ~12: /tmp/flutter sdk/packages/flutter/test/material/chip_test.dart: Chips with background color should have delete icon ripple and splash in the foreground                               
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following StateError was thrown running a test:
Bad state: No element
When the exception was thrown, this was the stack:
#0      Iterable.single (dart:core/iterable.dart:552:25)
#1      WidgetController.element (package:flutter_test/src/controller.dart:110:30)
#2      main.<anonymous closure> (file:///tmp/flutter%20sdk/packages/flutter/test/material/chip_test.dart:2199:46)
<asynchronous suspension>
#3      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:121:25)
<asynchronous suspension>
#4      TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:695:19)
<asynchronous suspension>
#7      TestWidgetsFlutterBinding._runTest (package:flutter_test/src/binding.dart:678:14)
#8      AutomatedTestWidgetsFlutterBinding.runTest.<anonymous closure> (package:flutter_test/src/binding.dart:1051:24)
#14     AutomatedTestWidgetsFlutterBinding.runTest (package:flutter_test/src/binding.dart:1048:15)
#15     testWidgets.<anonymous closure> (package:flutter_test/src/widget_tester.dart:118:22)
#16     Declarer.test.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:168:27)
<asynchronous suspension>
#17     Invoker.waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:250:15)
<asynchronous suspension>
#22     Invoker.waitForOutstandingCallbacks (package:test_api/src/backend/invoker.dart:247:5)
#23     Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:166:33)
#28     Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:165:13)
<asynchronous suspension>
#29     Invoker._onRun.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/invoker.dart:400:25)
<asynchronous suspension>
#43     _Timer._runTimers (dart:isolate-patch/timer_impl.dart:382:19)
#44     _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:416:5)
#45     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)
(elided 28 frames from class _FakeAsync, package dart:async, package dart:async-patch, and package stack_trace)
The test description was:
  Chips with background color should have delete icon ripple and splash in the foreground
════════════════════════════════════════════════════════════════════════════════════════════════════
03:43 +2170 ~12 -1: /tmp/flutter sdk/packages/flutter/test/material/chip_test.dart: Chips with background color should have delete icon ripple and splash in the foreground [E]                        
  Test failed. See exception logs above.
  The test description was: Chips with background color should have delete icon ripple and splash in the foreground

…or chips with background color (#41463)"

This reverts commit 588275e.
@jonahwilliams

Copy link
Copy Markdown
Contributor Author

TBR @clocksmith

@jonahwilliams
jonahwilliams merged commit c9ec26e into master Oct 24, 2019
@jonahwilliams
jonahwilliams deleted the revert-41463-fix_material_chip_bug branch October 24, 2019 01:11
@fluttergithubbot fluttergithubbot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Oct 24, 2019
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants