Repository navigation
send supportsRestart flag when starting an app - #4513
Merged
Merged
Conversation
Contributor
Author
| } | ||
|
|
||
| void _sendLogEvent(Map<String, dynamic> event) { | ||
| domain?._sendAppEvent(app, 'log', event); |
Contributor
There was a problem hiding this comment.
Could this lead to us missing log events and not knowing why?
Contributor
Author
There was a problem hiding this comment.
I'll log events to the flutter_tools log if they happen after the close() is called. This would be an unexpected condition however - the logs would be happening after the app has completed.
Contributor
|
LGTM |
a-siva
added a commit
to a-siva/flutter
that referenced
this pull request
Jan 4, 2018
includes the following CLs since the last roll - Further improve painting.dart documentation. (flutter#4505) - Add support for --strong option in the engine, create a strong mode version of platform file (flutter#4504) - Apply texture transform on Android (flutter#4513) - [fuchsia] Removed the flutter_app template. (flutter#4511) - This adds RPC call to set asset path. (flutter#4323) - Fix windows build by using lambda capture workaround (flutter#4514) - Add missing include for sk_malloc_throw
a-siva
added a commit
that referenced
this pull request
Jan 5, 2018
includes the following CLs since the last roll - Further improve painting.dart documentation. (#4505) - Add support for --strong option in the engine, create a strong mode version of platform file (#4504) - Apply texture transform on Android (#4513) - [fuchsia] Removed the flutter_app template. (#4511) - This adds RPC call to set asset path. (#4323) - Fix windows build by using lambda capture workaround (#4514) - Add missing include for sk_malloc_throw
cdotstout
pushed a commit
to cdotstout/flutter
that referenced
this pull request
Apr 3, 2018
* Apply transform to textures on android
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
includes the following CLs since the last roll - Further improve painting.dart documentation. (flutter#4505) - Add support for --strong option in the engine, create a strong mode version of platform file (flutter#4504) - Apply texture transform on Android (flutter#4513) - [fuchsia] Removed the flutter_app template. (flutter#4511) - This adds RPC call to set asset path. (flutter#4323) - Fix windows build by using lambda capture workaround (flutter#4514) - Add missing include for sk_malloc_throw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter runif the target device supports the restart command