Repository navigation
Ensure that docker tag is legal - #46035
Merged
Merged
Conversation
fluttergithubbot
added
the
c: contributor-productivity
gspencergoog
approved these changes
Dec 4, 2019
8 tasks done
tvolkert
added a commit
that referenced
this pull request
Dec 9, 2019
In #46035, we fixed the docker tag to be a legal tag during build. This PR makes the corresponding change to the tag during upload. Without this, we build the right tag, but then we try to upload the wrong tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our docker image build is failing with hotfix releases because the tag name is illegal
(cannot contain
+). This fixes the tag name to be valid before attempting to buildthe image.
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.