Skip to content

Fix isDense default for DropdownButtonFormField - #47160

Merged
shihaohong merged 2 commits into
flutter:masterfrom
shihaohong:fix-dropdown-button-form-field-is-dense
Dec 17, 2019
Merged

shihaohong merged 2 commits into
flutter:masterfrom
shihaohong:fix-dropdown-button-form-field-is-dense

Conversation

@shihaohong

@shihaohong shihaohong commented Dec 16, 2019 •

Copy link
Copy Markdown
Contributor

Description

Fixes a regression to the vertical size of DropdownButtonFormField caused by a change in the default value of isDense:

After Upgrading to Flutter v1.12.13+hotfix.5

Before Upgrading to v1.12.13+hotfix.5

Related Issues

Fixes #46844

Tests

I added the following tests:

  • A test to ensure that DropdownButtonFormField.isDense is true by default.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@shihaohong shihaohong added c: regression It was better in the past than it is now framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Dec 16, 2019

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice detective work! 🔎 💼

@shihaohong
shihaohong merged commit 7f56a61 into flutter:master Dec 17, 2019
@shihaohong
shihaohong deleted the fix-dropdown-button-form-field-is-dense branch December 17, 2019 00:40
@etrivinos

Copy link
Copy Markdown

isDense: true

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: regression It was better in the past than it is now framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DropdownButtonFormField has additional padding on top and bottom after upgrade to v1.12.13+hotfix.5

4 participants