Skip to content

Revert "Call setEditingState when text changes." - #47397

Merged
chingjun merged 1 commit into
masterfrom
revert-47177-setEditingState
Dec 19, 2019
Merged

chingjun merged 1 commit into
masterfrom
revert-47177-setEditingState

Conversation

@chingjun

Copy link
Copy Markdown
Contributor

Reverts #47177

Some of the internal tests are broken by this.

@chingjun
chingjun requested a review from dnfield December 19, 2019 00:52
@fluttergithubbot fluttergithubbot added a: tests "flutter test", flutter_test, or one of our tests p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Dec 19, 2019

@dnfield dnfield left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've re-opened #47137

@chingjun
chingjun merged commit d51956a into master Dec 19, 2019
dnfield added a commit to dnfield/flutter that referenced this pull request Dec 19, 2019
@dnfield
dnfield deleted the revert-47177-setEditingState branch February 17, 2020 22:31
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants