Repository navigation
Refresh indicator - #4788
Merged
Merged
Refresh indicator#4788
Conversation
added 3 commits
June 29, 2016 16:06
| Animation<Color> valueColor | ||
| }) : super(key: key, value: value, backgroundColor: backgroundColor, valueColor: valueColor); | ||
|
|
||
| final AnimationController controller; |
Contributor
Author
There was a problem hiding this comment.
Oops, no. A leftover from an earlier version, thanks for catching that.
Contributor
|
LGTM w/ coalescing the refreshes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation listens to the pointer instead of ScrollNotifications. At least for now, it's necessary to identify the scrollable that's driving the refresh indicator with a scrollableKey.
Fixes #4130