Skip to content

Revert "Do not rebuild Routes when a new opaque Route is pushed on top" - #49366

Merged
bparrishMines merged 1 commit into
masterfrom
revert-48900-theatre2
Jan 23, 2020
Merged

bparrishMines merged 1 commit into
masterfrom
revert-48900-theatre2

Conversation

@bparrishMines

Copy link
Copy Markdown
Contributor

Reverts #48900

Causing some failures in the Flutter Roll

@fluttergithubbot fluttergithubbot added p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Jan 23, 2020
@bparrishMines
bparrishMines merged commit 52c665d into master Jan 23, 2020
@bparrishMines
bparrishMines deleted the revert-48900-theatre2 branch January 23, 2020 19:32
goderbauer added a commit that referenced this pull request Jan 23, 2020
@goderbauer

Copy link
Copy Markdown
Member

LGTM

Turns out the problem here was missing calls to setState in the user's code. I am going to re-apply this PR after the issues have been fixed in the upstream code base.

goderbauer added a commit that referenced this pull request Jan 23, 2020
goderbauer added a commit that referenced this pull request Jan 24, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants