Repository navigation
Cleanup DevFS support and add unit test - #4960
Closed
johnmccutchan wants to merge 1 commit into
Closed
johnmccutchan wants to merge 1 commit into
johnmccutchan wants to merge 1 commit into
Conversation
johnmccutchan
commented
Jul 18, 2016
johnmccutchan
commented
Contributor
- Move devfs support into separate file
- Adapt to new interface
- Add unit test
Contributor
Author
Contributor
Author
|
Mostly done but still some WIP as I need to add more tests and fix a performance problem. |
Contributor
|
@johnmccutchan, can you merge to master - I committed changes in this area this morning - and reformat. It looks like you have some odd indents going on in these files. I'll review once you're ready. |
Contributor
Author
|
I'm going to close this pull request. I ended up getting hot reloading working on Android devices. Will send a more complete pull request tomorrow. |
aam
added a commit
to aam/flutter
that referenced
this pull request
Apr 11, 2018
Changes since last roll: ``` ed303c6 Roll dart sdk again. Previous roll required 23ae4fa098 revert. (flutter#4966) 8cd2727 Revert "Roll dart to 7764e6962e22afcf4b58c4e3cef3147330f3c884. (flutter#4960)" (flutter#4965) 9199b40 Revert "Support multiple shells in a single process. (flutter#4932)" (flutter#4964) 6baff4c Support multiple shells in a single process. (flutter#4932) 31c5bb4 Roll dart to 7764e6962e22afcf4b58c4e3cef3147330f3c884. (flutter#4960) c8e4c69 Avoid copying the contents of large platform message responses (flutter#4947) 5ff5272 Update to use new vulkan GrBackendRenderTarget ctor. (flutter#4962) 0c8993a Update to use new vulkan GrBackendRenderTarget ctor (part 2) (flutter#4963) 132ebdd Revert "Roll src/third_party/skia/ 9874bf1bc..52e16d984 (135 commits) (flutter#4958)" (flutter#4961) 11882ab Roll src/third_party/skia/ 9874bf1bc..52e16d984 (135 commits) (flutter#4958) ``` Add consts
aam
added a commit
that referenced
this pull request
Apr 11, 2018
Changes since last roll: ``` ed303c6 Roll dart sdk again. Previous roll required 23ae4fa098 revert. (#4966) 8cd2727 Revert "Roll dart to 7764e6962e22afcf4b58c4e3cef3147330f3c884. (#4960)" (#4965) 9199b40 Revert "Support multiple shells in a single process. (#4932)" (#4964) 6baff4c Support multiple shells in a single process. (#4932) 31c5bb4 Roll dart to 7764e6962e22afcf4b58c4e3cef3147330f3c884. (#4960) c8e4c69 Avoid copying the contents of large platform message responses (#4947) 5ff5272 Update to use new vulkan GrBackendRenderTarget ctor. (#4962) 0c8993a Update to use new vulkan GrBackendRenderTarget ctor (part 2) (#4963) 132ebdd Revert "Roll src/third_party/skia/ 9874bf1bc..52e16d984 (135 commits) (#4958)" (#4961) 11882ab Roll src/third_party/skia/ 9874bf1bc..52e16d984 (135 commits) (#4958) ``` Add consts
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Changes since last roll: ``` ed303c6 Roll dart sdk again. Previous roll required 23ae4fa098 revert. (flutter#4966) 8cd2727 Revert "Roll dart to 7764e6962e22afcf4b58c4e3cef3147330f3c884. (flutter#4960)" (flutter#4965) 9199b40 Revert "Support multiple shells in a single process. (flutter#4932)" (flutter#4964) 6baff4c Support multiple shells in a single process. (flutter#4932) 31c5bb4 Roll dart to 7764e6962e22afcf4b58c4e3cef3147330f3c884. (flutter#4960) c8e4c69 Avoid copying the contents of large platform message responses (flutter#4947) 5ff5272 Update to use new vulkan GrBackendRenderTarget ctor. (flutter#4962) 0c8993a Update to use new vulkan GrBackendRenderTarget ctor (part 2) (flutter#4963) 132ebdd Revert "Roll src/third_party/skia/ 9874bf1bc..52e16d984 (135 commits) (flutter#4958)" (flutter#4961) 11882ab Roll src/third_party/skia/ 9874bf1bc..52e16d984 (135 commits) (flutter#4958) ``` Add consts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.