Skip to content

Revert "Reland: [flutter_tool] Where possible, catch only subtypes of Exception" - #51960

Merged
jmagman merged 1 commit into
masterfrom
revert-51774-retry-retry-catch-exception
Mar 4, 2020
Merged

Revert "Reland: [flutter_tool] Where possible, catch only subtypes of Exception"#51960
jmagman merged 1 commit into
masterfrom
revert-51774-retry-retry-catch-exception

Conversation

@jmagman

@jmagman jmagman commented Mar 4, 2020

Copy link
Copy Markdown
Member

@jmagman
jmagman requested a review from zanderso March 4, 2020 20:39
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 4, 2020
@jmagman

jmagman commented Mar 4, 2020

Copy link
Copy Markdown
Member Author

Merging to green out the tree.

@jmagman
jmagman merged commit cbbb7ec into master Mar 4, 2020
@jmagman
jmagman deleted the revert-51774-retry-retry-catch-exception branch March 4, 2020 20:40
@zanderso

zanderso commented Mar 4, 2020

Copy link
Copy Markdown
Member

lgtm thanks!

@zanderso

zanderso commented Mar 5, 2020

Copy link
Copy Markdown
Member
  1. flutter_gallery_ios32__start_up
2020-03-04T12:13:31.425393: stderr: [ +785 ms] 2020-03-04 12:13:31.423 ios-deploy[59312:38371811] [ !! ] Error 0xe8000087: This application does not support this device's CPU type. AMDeviceSecureInstallApplication(0, device, url, options, install_callback, 0)
2020-03-04T12:13:31.426711: stderr: [   +1 ms] Could not run build/ios/iphoneos/Runner.app on 822ef7958bba573829d85eef4df6cbdd86593730.
2020-03-04T12:13:31.426806: stderr: [        ] Try launching Xcode and selecting "Product > Run" to fix the problem:
stderr: [        ]   open ios/Runner.xcworkspace
  1. flutter_gallery_ios32__transition_perf
2020-03-04T12:05:50.764876: stderr: 2020-03-04 12:05:50.763 ios-deploy[54599:38359066] [ !! ] Error 0xe8000087: This application does not support this device's CPU type. AMDeviceSecureInstallApplication(0, device, url, options, install_callback, 0)
2020-03-04T12:05:50.765515: stdout: 
2020-03-04T12:05:50.765606: stderr: Could not run build/ios/iphoneos/Runner.app on 822ef7958bba573829d85eef4df6cbdd86593730.
stdout: 
2020-03-04T12:05:50.765761: stderr: Try launching Xcode and selecting "Product > Run" to fix the problem:
stdout: 
2020-03-04T12:05:50.766070: stderr:   open ios/Runner.xcworkspace
  1. technical_debt__cost
Task failed with the following reason:
ERROR: Command "/home/flutter/.cocoon/flutter/bin/flutter doctor" failed with exit code 1.
  1. web_benchmarks_canvaskit
Task failed with the following reason:
ERROR: Command "/home/flutter/.cocoon/flutter/bin/flutter doctor" failed with exit code 1.
  1. web_benchmarks_html
Task failed with the following reason:
ERROR: Command "/home/flutter/.cocoon/flutter/bin/flutter doctor" failed with exit code 1.
  1. dartdoc
Task failed with the following reason:
ERROR: Command "/home/flutter/.cocoon/flutter/bin/flutter doctor" failed with exit code 1.

3 through 6 were zip not being installed on the vms. I'm not sure about 1 and 2, though it seems unrelated. I'll take a closer look.

@christopherfujino christopherfujino mentioned this pull request Mar 9, 2020
Closed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso Awaiting requested review from zanderso

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmagman @zanderso @googlebot @fluttergithubbot