Skip to content

Reland: [flutter_tool] Where possible, catch only subtypes of Exception - #51774

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
zanderso:retry-retry-catch-exception
Mar 4, 2020
Merged

fluttergithubbot merged 1 commit into
flutter:masterfrom
zanderso:retry-retry-catch-exception

Conversation

@zanderso

@zanderso zanderso commented Mar 2, 2020

Copy link
Copy Markdown
Member

Description

This PR is an attempt to reland #51440. It failed on the devicelab due to zip not being installed. See: #51654. Website docs updated here flutter/website#3749 and here flutter/website#3748

Related Issues

#8742

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.

@zanderso zanderso added tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Mar 2, 2020
@zanderso
zanderso requested a review from jonahwilliams March 2, 2020 17:55
@zanderso

zanderso commented Mar 2, 2020

Copy link
Copy Markdown
Member Author

This needs to wait for #51654

@jonahwilliams

Copy link
Copy Markdown
Contributor

Depending on the ETA for adding zip, you might land this without that particular try/catch fixed and leave a todo for it.

@fluttergithubbot

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@fluttergithubbot
fluttergithubbot merged commit 57c6721 into flutter:master Mar 4, 2020
jmagman added a commit that referenced this pull request Mar 4, 2020
jmagman added a commit that referenced this pull request Mar 4, 2020
@zanderso
zanderso deleted the retry-retry-catch-exception branch March 5, 2020 16:36
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants