Skip to content

[flutter_tools] support new SDK structure for sdkmanager - #51980

Merged
jonahwilliams merged 4 commits into
flutter:masterfrom
jonahwilliams:support_new_sdk_tools
Mar 5, 2020
Merged

jonahwilliams merged 4 commits into
flutter:masterfrom
jonahwilliams:support_new_sdk_tools

Conversation

@jonahwilliams

@jonahwilliams jonahwilliams commented Mar 5, 2020 •

Copy link
Copy Markdown
Contributor

Description

Teach the android SDK class about the cmdline tools, which accept licenses instead of the obsolete platform tools.

We're not currently able to accept android licenses in the latest SDK. We also need to update our documentation to explain which component to download.

#51712

@fluttergithubbot fluttergithubbot added tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Mar 5, 2020
@jonahwilliams

Copy link
Copy Markdown
Contributor Author

The documentation to update is here: https://flutter.dev/docs/get-started/install/macos#install-android-studio

@jonahwilliams
jonahwilliams marked this pull request as ready for review March 5, 2020 20:27

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You could add a comment about how this was in tools/bin prior to 3.6, though I'm happy with the git archeology of just looking at this PR and the issue.

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandy9808

Copy link
Copy Markdown

Sir is the error resolved or not?

@jmagman

jmagman commented Mar 30, 2020

Copy link
Copy Markdown
Member

This change is in v1.15.12, so currently master and dev channels.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants