Skip to content

When a list is scrolling, children can't be tapped - #5348

Merged
Hixie merged 1 commit into
flutter:masterfrom
Hixie:tap-scroll
Aug 11, 2016
Merged

Hixie merged 1 commit into
flutter:masterfrom
Hixie:tap-scroll

Conversation

@Hixie

@Hixie Hixie commented Aug 11, 2016

Copy link
Copy Markdown
Contributor

Fixes #5023 better than #5222 did.

The key difference is that since the controller's state is now used in the build function, we have to setState() in the _stop() function and in the status handler.

Also added more tests.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out code?

@abarth

abarth commented Aug 11, 2016

Copy link
Copy Markdown
Contributor

LGTM

@Hixie
Hixie merged commit 9c15407 into flutter:master Aug 11, 2016
@Hixie
Hixie deleted the tap-scroll branch August 11, 2016 20:40
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stopping flings should not count as a touch

2 participants