Repository navigation
When a list is scrolling, children can't be tapped - #5222
Conversation
|
Thank you very much for fixing! |
|
LGTM |
|
LGTM BUT NOT TO TRAVIS |
cb4f2b6 to
2fa8d33
Compare
|
The travis failure was because the gallery smoketest wasn't waiting for the scroll to settle before tapping the list, but that's now an ignored tap. |
|
@HansMuller you may be interested in the flutter gallery test change in this PR. I'm going to check this in some time after Travis goes green unless I hear otherwise. |
| .pump(const Duration(seconds: 1)); // Wait until the demo has opened. | ||
| await tester.pump(const Duration(seconds: 1)); // Wait until the demo has opened. | ||
|
|
||
| expect(find.text('Flutter Gallery'), findsNothing); |
There was a problem hiding this comment.
I feel like we've changed the case of Flutter gallery and Flutter Gallery at times, hopefully this is finding or not finding the right thing. :)
|
This blocked touches on lists for much longer than expected. I'm not sure if we're missing a setState when the animation ends or if we're just letting the animation go for much longer than it should, but either way, I'm reverting this for now. |
4 participants
Fixes #5023