Skip to content

Add API to services package that overrides HTTP ban - #54243

Merged
mehmetf merged 7 commits into
flutter:masterfrom
mehmetf:master
Apr 11, 2020
Merged

Add API to services package that overrides HTTP ban#54243
mehmetf merged 7 commits into
flutter:masterfrom
mehmetf:master

Conversation

@mehmetf

@mehmetf mehmetf commented Apr 8, 2020

Copy link
Copy Markdown
Contributor

This is being submitted in preparation of breaking change described in dart-lang/sdk#40548.

The Dart SDK support for this is added dart-lang/sdk@74a20b7.

Following this PR, I will draft and send out an announcement for flutter-announce@. Afterwards, I will submit the change to engine to ban HTTP by default on iOS and Android.

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 8, 2020
@mehmetf mehmetf changed the title Add API to flutter.services package that overrides HTTP ban Add API to services package that overrides HTTP ban Apr 8, 2020
@mehmetf
mehmetf requested a review from Hixie April 8, 2020 00:01
@mehmetf

mehmetf commented Apr 8, 2020

Copy link
Copy Markdown
Contributor Author

@Hixie This PR is ready for review. If you prefer me to send the breaking change announcement first, let me know. I thought I would add the API first in case people want to jump ahead and make the change. It will be a noop until I submit the engine change.

goderbauer
goderbauer reviewed Apr 8, 2020
View reviewed changes

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please leave the PR template in place and fill it out when opening PRs? It makes it easier to spot whether this change is a breaking change that may require a migration guide. Even though the description talks about a breaking change, this doesn't seem to be one?

Comment thread packages/flutter/lib/src/services/platform_network.dart Outdated
Comment thread packages/flutter/lib/src/services/platform_network.dart Outdated
Comment thread packages/flutter/test/services/platform_network_test.dart Outdated
@goderbauer

goderbauer commented Apr 8, 2020

Copy link
Copy Markdown
Member

Also: it appears that one of the new tests is failing on cirrus.

@mehmetf

mehmetf commented Apr 8, 2020

Copy link
Copy Markdown
Contributor Author

Thanks @goderbauer.

No this change itself is not a breaking change. The upcoming engine change will be a breaking change that will be announced.

I removed the failing test. I am already doing the connection tests in the Dart SDK and the negative test case here should be enough from Flutter's point of view since all we care is that we are using the right symbol.

@mehmetf

mehmetf commented Apr 9, 2020

Copy link
Copy Markdown
Contributor Author

OK this is ready for another round. @goderbauer Thanks!

chunhtai
chunhtai reviewed Apr 9, 2020
View reviewed changes
Comment thread packages/flutter/test/services/platform_network_test.dart Outdated
chunhtai
chunhtai reviewed Apr 10, 2020
View reviewed changes
Comment thread packages/flutter/test/services/platform_network_test.dart
Comment thread packages/flutter/test/services/platform_network_test.dart
chunhtai
chunhtai approved these changes Apr 10, 2020
View reviewed changes

@chunhtai chunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/flutter/test/services/platform_network_test.dart
Comment thread packages/flutter/lib/src/services/platform_network.dart Outdated
@fluttergithubbot

fluttergithubbot commented Apr 10, 2020

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite web_tests-4-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite hostonly_devicelab_tests-3_last-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@mehmetf
mehmetf merged commit 9eb2a2a into flutter:master Apr 11, 2020
mehmetf added a commit that referenced this pull request Apr 11, 2020
@mehmetf
Revert "Add API to services package that overrides HTTP ban (#54243)"
a20abba 
This reverts commit 9eb2a2a.
@mehmetf mehmetf mentioned this pull request Apr 11, 2020
Merged
mehmetf added a commit that referenced this pull request Apr 11, 2020
@mehmetf
Revert "Add API to services package that overrides HTTP ban (#54243)" (…
35ed1cc 
…#54519)

This reverts commit 9eb2a2a.
@mehmetf

mehmetf commented Apr 11, 2020

Copy link
Copy Markdown
Contributor Author

I had to revert this since one of the tests breaks on web. The test needs to access dart:io HttpClient. How do I exclude it from web test suite? @yjbanov

fluttergithubbot pushed a commit that referenced this pull request Apr 13, 2020
@mehmetf
Reland "Add API to services package that overrides HTTP ban (#54243)" (…
d1e0528 
…#54522)
mehmetf added a commit that referenced this pull request Apr 14, 2020
@mehmetf
Revert "Reland "Add API to services package that overrides HTTP ban (#…
0cf1872 
…54243)" (#54522)"

This reverts commit d1e0528.
mehmetf added a commit that referenced this pull request Apr 14, 2020
@mehmetf
Revert "Reland "Add API to services package that overrides HTTP ban (#…
6a983e7 
…54243)" (#54522)" (#54779)

This reverts commit d1e0528.
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer goderbauer left review comments
@chunhtai chunhtai chunhtai approved these changes
@Hixie Hixie Awaiting requested review from Hixie

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mehmetf @goderbauer @fluttergithubbot @chunhtai @googlebot