Repository navigation
Chips text scaling - #57745
Merged
Merged
Chips text scaling#57745
Conversation
fluttergithubbot
added
p: material_ui
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
Author
|
|
rami-a
reviewed
May 27, 2020
rami-a
approved these changes
May 28, 2020
clocksmith
reviewed
May 29, 2020
clocksmith
left a comment
clocksmith
left a comment
Contributor
There was a problem hiding this comment.
I think this is missing new tests to test different paddings for different text scale factors
Contributor
Author
There is already a text that does this. It is in chip_test.dart and the name of the test is: Chip responds to textScaleFactor |
HansMuller
reviewed
Jun 2, 2020
HansMuller
approved these changes
Jun 2, 2020
JoseAlba
added
waiting for tree to go green
and removed
waiting for tree to go green
labels
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improved text scaling for chips widget. Currently the chips component is being themed within the default theme data using the ChipThemeData.fromDefaults constructor. Removed the labelPadding from being defined in the ChipTheme and moved it to the raw chip. Similar to how the defaults are set in the newer widgets like the Slider.
Currently there is no text scaling with the Chips component. By default the chip component has label padding of 8px in the horizontal axis. Now the chip starts with 8px on each side and as text scaling gets closer to 2 the label padding is linearly interpolated from 8px to 4px. Once the widget has a text scaling of 2 or higher than the label padding remains 4px.
Tests
I added the following tests:
Updated test in
chip_test.dartandchip_theme_test.dartChecklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.