[flutter_tools] Support latest IntelliJ via Jetbrain toolbox by Nash0x7E2 · Pull Request #57963 · flutter/flutter

Nash0x7E2 · 2020-05-25T19:42:36Z

Description

Flutter tools do not recognize the plugin directory of IntelliJ IDEA 2020.1 (installed via Jetbrains Toolbox).

This PR updates the _pluginsPath to support the plugins subdirectory used by Jetbrains Toolbox.

Related Issues

Ref: #47583
Ref: #57642

Tests

Existing test passing

Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I signed the [CLA].
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I updated/added relevant documentation (doc comments with ///).
All existing and new tests are passing.
The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

No, no existing tests failed, so this is not a breaking change.

fluttergithubbot · 2020-05-25T19:42:39Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Nash0x7E2 · 2020-05-26T22:10:41Z

Thanks for the suggestions @jmagman. I've added the changes you requested 🙂

christopherfujino · 2020-05-26T23:37:35Z

    if (split.length < 2) {
      return null;
    }
+    final int major = int.parse(split[0]);


why did you parse these into ints?

These lines were moved from line 923. Not the best way to do it, but that's how it was done before.

I used it to check the major and minor version numbers. It was simpler to compare these as int since the can be easily converted back to strings.

Oh wait @christopherfujino is right, I totally misread this.

Right, in the previous version I used an if to check the version numbers. I think the ints can be removed now since they are not used. Can I push an update to this?

You can revert them back to Strings now that you aren't actually checking if it's > 2020

Ahh, again demonstrating the difficulty of reviewing different versions of a PR on github. Thanks for updating, @Nash0x7E2

jmagman · 2020-05-26T23:40:40Z

It would be awesome to get some tests for the plugins directory logic, and we don't have any currently. You mind if I push some to your fork?

Nash0x7E2 · 2020-05-26T23:41:00Z

@jmagman sure, go for it

jmagman · 2020-05-26T23:46:09Z

@@ -1,38 +0,0 @@
-<?xml version='1.0' encoding='UTF-8'?>


The original intellij plugins path checking on mac tests thought they were using these two Info.plists, but they actually weren't...
Unused, delete.

christopherfujino

LGTM with a nit to add a comment documenting why we have two paths

christopherfujino · 2020-05-27T00:12:07Z

      '$id$major.$minor',
+      'plugins',
    );
+    if (!globals.fs.isDirectorySync(pluginsPath)) {


could we add a comment here to explain why we have two paths?

👍 I had suggested a comment in #57963 (comment)

Code updated with comment 👍

ovestoerholt · 2020-10-11T01:07:48Z

Does not work for me with Flutter 1.22.1 (neither did it work on earlier versions...)

flutter doctor 
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 1.22.1, on Mac OS X 10.15.7 19H2, locale nb-NO)
 
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
[!] Android Studio (version 4.0)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[!] Android Studio (version 4.1)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[!] Android Studio
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[!] Android Studio
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    ✗ Android Studio not found at /Users/ovestorholt/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-2/193.6453388/Android Studio 4.0 Preview.app/Contents
[!] Android Studio
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    ✗ Android Studio not found at /Users/ovestorholt/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.6811877/Android Studio 4.2 Preview.app/Contents
[!] IntelliJ IDEA Ultimate Edition (version 2020.2.3)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] VS Code (version 1.49.2)
[✓] Connected device (2 available)

ozzy1873 · 2020-10-15T15:24:31Z

Same problem here with v1.22.1

jmagman · 2020-10-15T17:22:13Z

Please file new issues and completely fill out the template so we can triage instead of commenting on merged PRs. Thanks!

[flutter_tools] Support latest IntelliJ via Jetbrain toolbox

e77f1d1

fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 25, 2020

googlebot added the cla: yes label May 25, 2020

Fixed warnings

ae96093

jmagman added the t: flutter doctor Problem related to the "flutter doctor" tool label May 26, 2020

jmagman requested a review from christopherfujino May 26, 2020 21:42

jmagman requested changes May 26, 2020

View reviewed changes

Comment thread packages/flutter_tools/lib/src/doctor.dart Outdated

Comment thread packages/flutter_tools/lib/src/doctor.dart Outdated

Nash0x7E2 added 2 commits May 26, 2020 18:02

remove trailing tab

d6eb051

update plugin return path

6205755

christopherfujino reviewed May 26, 2020

View reviewed changes

IntelliJValidatorOnMac tests

96e2b91

jmagman reviewed May 26, 2020

View reviewed changes

remove int parse

7981c4f

jmagman approved these changes May 27, 2020

View reviewed changes

christopherfujino approved these changes May 27, 2020

View reviewed changes

document reason for two paths

50edf17

jmagman merged commit 428ce08 into flutter:master May 27, 2020

christopherfujino mentioned this pull request May 27, 2020

[flutter_tools] Intellij 2020 plugins not detected by doctor #54867

Closed

jparound30 mentioned this pull request Jun 6, 2020

[flutter_tools] Support IntelliJ 2020.1 and later on Linux and Windows #58853

Merged

9 tasks done

christopherfujino mentioned this pull request Jun 10, 2020

flutter doctor not detecting Flutter and Dart IntelliJ plugin installation. #36414

Closed

jonahwilliams mentioned this pull request Oct 10, 2020

Flutter does not see IDEA installed via Jetbrains Toolbox #47583

Closed

lennondotw mentioned this pull request Feb 11, 2022

IntelliJ IDEA installed with JetBrains Toolbox duplicated in flutter doctor #98276

Closed

Conversation

Nash0x7E2 commented May 25, 2020

Description

Related Issues

Tests

Checklist

Breaking Change

Uh oh!

fluttergithubbot commented May 25, 2020

Uh oh!

Uh oh!

Uh oh!

Nash0x7E2 commented May 26, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmagman May 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmagman commented May 26, 2020

Uh oh!

Nash0x7E2 commented May 26, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ovestoerholt commented Oct 11, 2020

Uh oh!

ozzy1873 commented Oct 15, 2020

Uh oh!

jmagman commented Oct 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jmagman May 26, 2020 •

edited

Loading

jmagman commented Oct 15, 2020 •

edited

Loading