Repository navigation
Fixed leading app bar button width constraint - #5802
Merged
Merged
Conversation
Contributor
|
LGTM. |
Contributor
Author
|
Fixes #5804 |
Contributor
|
Can/should we test this? |
Contributor
Author
|
Yes we should test this. #5811 |
rmacnak-google
added a commit
that referenced
this pull request
Jul 19, 2018
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
Jul 19, 2018
482469b Roll Dart to 937ee2e8ca4b76499e24cd463f07bfb736bccd74. (flutter#5800) bb323c1 Revert "Roll src/third_party/skia 9e0d7e4072e4..297c3c8e85bd (62 commits) (flutter#5802)" (flutter#5803) 0bf69f0 Roll src/third_party/skia 9e0d7e4072e4..297c3c8e85bd (62 commits) (flutter#5802)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The width constraint for the leading app bar button should be as big as an icon button (not an icon).