Repository navigation
[flutter_tools] inject output preferences at the top level - #58875
Merged
jonahwilliams merged 5 commits intoJun 10, 2020
Merged
Conversation
fluttergithubbot
added
the
tool
Contributor
Author
|
This will also work towards unblocking testWithoutContext when using TestFlutterCommandRunner |
| expect(preferences.showColor, true); | ||
| expect(preferences.wrapText, false); | ||
| // this calls context | ||
| // expect(preferences.wrapColumn, 80); |
Contributor
There was a problem hiding this comment.
is this supposed to be commented out?
| } | ||
| } | ||
|
|
||
| // If we're not writing to a terminal with a defined width, then don't wrap |
Contributor
There was a problem hiding this comment.
Looks like the logic changed and this comment is no longer accurate.
Contributor
Author
There was a problem hiding this comment.
Fixed, and added test case that we default to 100 if terminalColumns is null
…utter into lift_output_preferences
jmagman
added a commit
that referenced
this pull request
Jun 10, 2020
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
…8875) The tool was setting the output preferences in a sub-context. Originally these were not injected before the arg parsers were created, though that was fixed by the lazy command creation. Once local engine is removed, the inner flutter_command Zone can be removed.
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
…lutter#58875)" (flutter#59197) This reverts commit dca6320.
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…8875) The tool was setting the output preferences in a sub-context. Originally these were not injected before the arg parsers were created, though that was fixed by the lazy command creation. Once local engine is removed, the inner flutter_command Zone can be removed.
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…lutter#58875)" (flutter#59197) This reverts commit dca6320.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The tool was setting the output preferences in a sub-context. Originally these were not injected before the arg parsers were created, though that was fixed by the lazy command creation. Once local engine is removed, the inner flutter_command Zone can be removed.