Skip to content

Characters package - #59267

Merged
fluttergithubbot merged 2 commits into
flutter:masterfrom
justinmc:characters-add
Jun 15, 2020
Merged

fluttergithubbot merged 2 commits into
flutter:masterfrom
justinmc:characters-add

Conversation

@justinmc

Copy link
Copy Markdown
Contributor

Description

This PR simply adds the characters package to Flutter in preparation for #53381.

Related Issues

#53381

Tests

None, tests are added in #53381.

Breaking Change

None.

@justinmc
justinmc requested a review from HansMuller June 11, 2020 15:19
@justinmc justinmc self-assigned this Jun 11, 2020
@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jun 11, 2020

@HansMuller HansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM however it looks like you'll need to make another fix to accommodate the version changes (there are still some failing tests)

@bluemix

bluemix commented Jun 24, 2020

Copy link
Copy Markdown

Unless I include characters pakcage in pubspec.yaml, i still getting this issue.

mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants