Repository navigation
flutter.gradle: collect list of Android plugins from .flutter-plugins-dependencies - #59294
Merged
fluttergithubbot merged 1 commit intoJun 18, 2020
Merged
Conversation
9 of 13 tasks
blasten
reviewed
Jun 12, 2020
There was a problem hiding this comment.
nit: empty line - Typically we use empty lines to separate logical procedures for better readability.
Contributor
Author
There was a problem hiding this comment.
empty line removed
Member
|
@blasten @igorakkerman Is this ready to land? |
Contributor
Author
|
@zanderso Yes. Please let me know if I need to add a tag or something. Thanks! |
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
…-plugins-dependencies (flutter#59294)" (flutter#59810) This reverts commit 947b48e.
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…-plugins-dependencies (flutter#59294)" (flutter#59810) This reverts commit 947b48e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note: This is a clone of PR #57907, which got merged and later rolled back.
Some packages include transitive dependencies to their web version, e.g.
PR #54407 introduced a change to the default
settings.gradlefile. The required plugins are now loaded throughapp_plugin_loader.gradle, which retrieves the list from.flutter-plugins-dependencies. Instead, the current logic influtter.gradlestill relies on.flutter-plugins, which lists transitive non-Android plugins.This leads to a warning in the build:
The pull request now uses the same logic as in
app_plugin_loader.gradleto retrieve the list of Android plugins.Note: The same logic now exists in 3 different locations and should be extracted to a separate file. The 3 locations are:
Related Issues
#57907 (original PR)
#55827
#57863
#59732
Tests
Please help me understand if / where to add tests for the changes. Thank you!
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.