Skip to content

flutter.gradle: collect list of Android plugins from .flutter-plugins-dependencies - #59294

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
igorakkerman:fix/android-plugins-list
Jun 18, 2020
Merged

fluttergithubbot merged 1 commit into
flutter:masterfrom
igorakkerman:fix/android-plugins-list

Conversation

@igorakkerman

@igorakkerman igorakkerman commented Jun 12, 2020 •

Copy link
Copy Markdown
Contributor

Description

Note: This is a clone of PR #57907, which got merged and later rolled back.

Some packages include transitive dependencies to their web version, e.g.

  • location -> location_web
  • firebase_core -> firebase_core_web

PR #54407 introduced a change to the default settings.gradle file. The required plugins are now loaded through app_plugin_loader.gradle, which retrieves the list from .flutter-plugins-dependencies. Instead, the current logic in flutter.gradle still relies on .flutter-plugins, which lists transitive non-Android plugins.

This leads to a warning in the build:

Plugin project :location_web not found. Please update settings.gradle.

The pull request now uses the same logic as in app_plugin_loader.gradle to retrieve the list of Android plugins.

Note: The same logic now exists in 3 different locations and should be extracted to a separate file. The 3 locations are:

  • app_plugin_loader.gradle
  • module_plugin_loader.gradle
  • flutter.gradle

Related Issues

#57907 (original PR)

#55827
#57863
#59732

Tests

Please help me understand if / where to add tests for the changes. Thank you!

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 12, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: empty line - Typically we use empty lines to separate logical procedures for better readability.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line removed

@blasten blasten left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso

Copy link
Copy Markdown
Member

@blasten @igorakkerman Is this ready to land?

@igorakkerman

igorakkerman commented Jun 18, 2020 •

Copy link
Copy Markdown
Contributor Author

@zanderso Yes. Please let me know if I need to add a tag or something. Thanks!

@fluttergithubbot
fluttergithubbot merged commit 947b48e into flutter:master Jun 18, 2020
jonahwilliams pushed a commit that referenced this pull request Jun 18, 2020
jonahwilliams pushed a commit that referenced this pull request Jun 18, 2020
zljj0818 pushed a commit to zljj0818/flutter that referenced this pull request Jun 22, 2020
zljj0818 pushed a commit to zljj0818/flutter that referenced this pull request Jun 22, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants