Repository navigation
Implement delayed key event synthesis support for framework - #59358
Merged
fluttergithubbot merged 5 commits intoJun 25, 2020
Merged
Conversation
fluttergithubbot
added
the
framework
gspencergoog
changed the title
gspencergoog
changed the title
fluttergithubbot
added
the
a: tests
gspencergoog
marked this pull request as ready for review
June 13, 2020 00:38
Member
|
What would happen if multiple Flutter Views are on top of each other? I assume this would lead to n^2 key events in rapid succession, but its not clear if there would be any notable side effects of that. |
gspencergoog
requested review from
goderbauer and
jason-simmons
and removed request for
jason-simmons
June 17, 2020 20:51
goderbauer
approved these changes
Jun 17, 2020
Member
There was a problem hiding this comment.
nit: maybe mentioned what "handled" (or returning true) means, e.g. that the event will stop propagating and nobody else will see them?
Member
There was a problem hiding this comment.
Should we assert here that if the keyEventHandler was provided it returned true/false (and not null)? Assuming that returning null from keyEventHandler is illegal.
Member
There was a problem hiding this comment.
If null is illegal, let's document that on RawKeyEventHandler as well.
Member
There was a problem hiding this comment.
maybe link to [addListener] as well from here and say how that's different then receiving the key events from here.
gspencergoog
force-pushed
the
framework_synchronous_keys
branch
2 times, most recently
from
June 22, 2020 23:04
f725ee0 to
0719bce
Compare
|
Google testing passed! |
gspencergoog
changed the title
gspencergoog
force-pushed
the
framework_synchronous_keys
branch
from
June 25, 2020 01:05
0719bce to
2571236
Compare
|
Started Google testing for this PR |
|
Google testing passed! |
gspencergoog
changed the title
gspencergoog
added a commit
to flutter-team-archive/engine
that referenced
this pull request
Jul 17, 2020
) This implements the design in flutter.dev/go/handling-synchronous-keyboard-events for Android. I started with Android, but this will be used for all platforms as we add them. The related framework PR is: flutter/flutter#59358 (which has already landed)
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
zhongdaiqi
pushed a commit
to zhongdaiqi/flutter_flutter
that referenced
this pull request
Oct 9, 2026
…tter-team-archive/engine#19024) This implements the design in flutter.dev/go/handling-synchronous-keyboard-events for Android. I started with Android, but this will be used for all platforms as we add them. The related framework PR is: flutter/flutter#59358 (which has already landed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This implements the design in https://flutter.dev/go/handling-synchronous-keyboard-events for Android.
I started with Android, but this will be used for all platforms as we add them.
The related engine PR is: flutter-team-archive/engine#19024
Related Issues
Tests
Breaking Change