Repository navigation
[flutter_tools] make expando on vm service null safe to handle web stuff - #59624
Merged
fluttergithubbot merged 2 commits intoJun 18, 2020
Merged
Conversation
fluttergithubbot
added
the
tool
jonahwilliams
changed the title
jmagman
approved these changes
Jun 17, 2020
jmagman
left a comment
jmagman
left a comment
Member
There was a problem hiding this comment.
Is it concerning these were null?
Contributor
Author
|
No, that is expected for the web still. The fix is a bit more involved there, but only for launching devtools |
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #59606
null check on the extension method (because its a static method, so
thiscan be null - NNBD when). The vm service will be null when running on the web - the devtools logic needs to be slightly tweaked here, but that fix is potentially riskier so easier to stop the crash for now