Skip to content

[flutter_tools] handle NPE in list views method - #59626

Merged
jonahwilliams merged 1 commit into
flutter:masterfrom
jonahwilliams:list_views_nsm
Jun 17, 2020
Merged

jonahwilliams merged 1 commit into
flutter:masterfrom
jonahwilliams:list_views_nsm

Conversation

@jonahwilliams

@jonahwilliams jonahwilliams commented Jun 17, 2020 •

Copy link
Copy Markdown
Contributor

Description

Fixes #59608

The VmService getter can be null, handle that in the listViews method. NNBD when

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 17, 2020
@jonahwilliams jonahwilliams changed the title handle NPE in list views method [flutter_tools] handle NPE in list views method Jun 17, 2020

@christopherfujino christopherfujino left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, LGTM

@jonahwilliams
jonahwilliams merged commit 802c4b0 into flutter:master Jun 17, 2020
@jonahwilliams
jonahwilliams deleted the list_views_nsm branch June 17, 2020 17:53
@zanderso

Copy link
Copy Markdown
Member

Thanks!

zljj0818 pushed a commit to zljj0818/flutter that referenced this pull request Jun 22, 2020
Fixes flutter#59608

The VmService getter can be null, handle that in the listViews method. NNBD when
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
Fixes flutter#59608

The VmService getter can be null, handle that in the listViews method. NNBD when
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

resident runner NSM crash when listing views

5 participants