Repository navigation
[ExpansionPanelList] adds dividerColor property - #59641
Merged
fluttergithubbot merged 3 commits intoJun 17, 2020
Merged
Conversation
fluttergithubbot
added
p: material_ui
shihaohong
approved these changes
Jun 17, 2020
| expect(box.size.width, equals(736.0)); | ||
| }); | ||
|
|
||
| testWidgets('ExpansionPanelList respect dividerColor', (WidgetTester tester) async { |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| testWidgets('ExpansionPanelList respect dividerColor', (WidgetTester tester) async { | |
| testWidgets('ExpansionPanelList respects dividerColor', (WidgetTester tester) async { |
| expect(decoration.border.top.color, dividerColor); | ||
| }); | ||
|
|
||
| testWidgets('ExpansionPanelList.Radio respects DividerColor', (WidgetTester tester) async { |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| testWidgets('ExpansionPanelList.Radio respects DividerColor', (WidgetTester tester) async { | |
| testWidgets('ExpansionPanelList.radio respects DividerColor', (WidgetTester tester) async { |
| ), | ||
| ], | ||
| ), | ||
| ) |
Contributor
There was a problem hiding this comment.
nit: trailing comma
Suggested change
| ) | |
| ), |
| final DecoratedBox decoratedBox = tester.widget(find.byType(DecoratedBox).last); | ||
| final BoxDecoration decoration = decoratedBox.decoration as BoxDecoration; | ||
|
|
||
| // For the last DecoratedBox, we will have a Border.top. |
Contributor
There was a problem hiding this comment.
nit: slightly more description
Suggested change
| // For the last DecoratedBox, we will have a Border.top. | |
| // For the last DecoratedBox, we will have a Border.top with the provided dividerColor. |
| final DecoratedBox decoratedBox = tester.widget(find.byType(DecoratedBox).last); | ||
| final BoxDecoration boxDecoration = decoratedBox.decoration as BoxDecoration; | ||
|
|
||
| // For the last DecoratedBox, we will have a Border.top. |
Contributor
There was a problem hiding this comment.
nit: slightly more description
Suggested change
| // For the last DecoratedBox, we will have a Border.top. | |
| // For the last DecoratedBox, we will have a Border.top with the provided dividerColor. |
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
vasilich6107
added a commit
to artflutter/whatsup_flutter_june2020
that referenced
this pull request
Jul 8, 2020
Expanded divider control
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Exposes the
dividerColorproperty ofMergeableMaterialto change the color of dividers whenExpansionPanel.isExpandedis false.Related Issues
#51321
Tests
I added the following tests:
dividerColoris respected byExpansionPanelListandExpansionPanelList.radio.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.