Skip to content

Manual engine roll to update format of compileExpression RPC response - #59717

Merged
fluttergithubbot merged 2 commits into
masterfrom
remove_nested_result_vmservice
Jun 18, 2020
Merged

fluttergithubbot merged 2 commits into
masterfrom
remove_nested_result_vmservice

Conversation

@bkonyi

@bkonyi bkonyi commented Jun 17, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@fluttergithubbot

Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added engine flutter/engine related. See also e: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 17, 2020
@bkonyi
bkonyi requested a review from aam June 17, 2020 22:27
@fluttergithubbot
fluttergithubbot merged commit c7a37c7 into master Jun 18, 2020
@fluttergithubbot
fluttergithubbot deleted the remove_nested_result_vmservice branch June 18, 2020 16:18
cbracken added a commit to cbracken/flutter that referenced this pull request Jun 18, 2020
…C response (flutter#59717)"

Failing dev/integration_tests/ui/test_driver/keyboard_resize_test.dart
Also timing out on new_gallery_ios__transition_perf

This reverts commit c7a37c7.
cbracken added a commit that referenced this pull request Jun 18, 2020
…C response (#59717)" (#59774)

Failing dev/integration_tests/ui/test_driver/keyboard_resize_test.dart
Also timing out on new_gallery_ios__transition_perf

This reverts commit c7a37c7.
zljj0818 pushed a commit to zljj0818/flutter that referenced this pull request Jun 22, 2020
zljj0818 pushed a commit to zljj0818/flutter that referenced this pull request Jun 22, 2020
…C response (flutter#59717)" (flutter#59774)

Failing dev/integration_tests/ui/test_driver/keyboard_resize_test.dart
Also timing out on new_gallery_ios__transition_perf

This reverts commit c7a37c7.
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
…C response (flutter#59717)" (flutter#59774)

Failing dev/integration_tests/ui/test_driver/keyboard_resize_test.dart
Also timing out on new_gallery_ios__transition_perf

This reverts commit c7a37c7.
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

engine flutter/engine related. See also e: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants