Repository navigation
Make flutter and dart scripts invoke their batch file equivalents on Windows - #59789
Merged
Merged
Conversation
…ning under MINGW (i.e. git-bash)
gspencergoog
added
the
tool
|
|
||
| if [[ $OS =~ MINGW.* ]]; then | ||
| # If we're on Windows, invoke the batch script instead, to get proper locking. | ||
| exec "${BIN_DIR}/dart.bat" "$@" |
Contributor
There was a problem hiding this comment.
do we want to exit after this?
Contributor
Author
There was a problem hiding this comment.
The exec command completely substitutes the given command for the current process, so there's no need to exit (it already has exited by invoking the other script).
Contributor
Author
There was a problem hiding this comment.
Also, the final return value is the return value of the other script.
Contributor
There was a problem hiding this comment.
I guess that means we should never reach the other switch cases on MINGW anyway?
Contributor
Author
There was a problem hiding this comment.
What other switch cases? I mean, no, it'll never even reach the "fi" because it execs the other process immediately.
9 of 13 tasks
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
…Windows (flutter#59789) This makes the flutter and dart scripts invoke their batch file equivalents if running under MINGW (i.e. git-bash) on Windows. This allows for proper locking, and makes sure that people aren't using two different (and non-mutally-aware) locking systems when running flutter on Windows. I also fixed a couple of places where we look for MINGW32, which fails under MINGW64. It just looks for MINGW now.
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…Windows (flutter#59789) This makes the flutter and dart scripts invoke their batch file equivalents if running under MINGW (i.e. git-bash) on Windows. This allows for proper locking, and makes sure that people aren't using two different (and non-mutally-aware) locking systems when running flutter on Windows. I also fixed a couple of places where we look for MINGW32, which fails under MINGW64. It just looks for MINGW now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes the
flutteranddartscripts invoke their batch file equivalents if running under MINGW (i.e. git-bash) on Windows.This allows for proper locking, and makes sure that people aren't using two different (and non-mutally-aware) locking systems when running flutter on Windows.
I also fixed a couple of places where we look for MINGW32, which fails under MINGW64. It just looks for MINGW now.
Related Issues