Skip to content

Revert "[PageTransitionsBuilder] Fix 'ZoomPageTransition' built more than once" - #59992

Merged
renyou merged 1 commit into
masterfrom
revert-58686-fix-zoom-page-transition-build
Jun 23, 2020
Merged

renyou merged 1 commit into
masterfrom
revert-58686-fix-zoom-page-transition-build

Conversation

@renyou

@renyou renyou commented Jun 22, 2020

Copy link
Copy Markdown
Contributor

This breaks Google internal tests: b/159612674

@fluttergithubbot fluttergithubbot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Jun 22, 2020
@renyou
renyou requested a review from shihaohong June 22, 2020 16:01
@renyou
renyou requested a review from Hixie June 22, 2020 16:01

@shihaohong shihaohong left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc/ @AlexVincent525, who worked on the PR. I'll try to debug this issue internally, since I'm not sure how this change would have broken the test in question.

@AlexV525

Copy link
Copy Markdown
Member

cc/ @AlexVincent525, who worked on the PR.

Thanks for letting me know, I'll keep in touch with this one.

@renyou
renyou merged commit 15a2815 into master Jun 23, 2020
@renyou
renyou deleted the revert-58686-fix-zoom-page-transition-build branch June 23, 2020 11:53
shihaohong pushed a commit that referenced this pull request Jun 24, 2020
fluttergithubbot pushed a commit that referenced this pull request Jun 25, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants