Skip to content

Make module run script names unique - #60228

Merged
jmagman merged 1 commit into
flutter:masterfrom
jmagman:module-name-script
Jun 24, 2020
Merged

Make module run script names unique#60228
jmagman merged 1 commit into
flutter:masterfrom
jmagman:module-name-script

Conversation

@jmagman

@jmagman jmagman commented Jun 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Make the script phase name unique per module so multiple modules can be embedded into a host app. Ran the integration tests, and you can see the updated script names there.

Related Issues

Fixes #60223

Tests

Integration tests already test that these scripts are embedded and run.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. a: existing-apps Integration with existing apps via the add-to-app flow labels Jun 24, 2020
@jmagman jmagman self-assigned this Jun 24, 2020
@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jun 24, 2020
jmagman
jmagman commented Jun 24, 2020
View reviewed changes
Comment thread dev/integration_tests/ios_add2app/ios_add2app.xcodeproj/project.pbxproj
buildPhases = (
4375EE880A727341E9C9A57D /* [CP] Check Pods Manifest.lock */,
CE6831C2A33C6C5C84521FDE /* [CP-User] Run Flutter Build Script */,
52B3E7E8995E582399C42407 /* [CP-User] Run Flutter Build ios_add2app_flutter Script */,

@jmagman jmagman Jun 24, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an example host project, and was updated by running the integration tests.

christopherfujino
christopherfujino approved these changes Jun 24, 2020
View reviewed changes

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flutter-github-sync

flutter-github-sync commented Jun 24, 2020

Copy link
Copy Markdown

Started Google testing for this PR

@flutter-github-sync

flutter-github-sync commented Jun 24, 2020

Copy link
Copy Markdown

Google testing passed!

@jmagman
jmagman merged commit 0486ceb into flutter:master Jun 24, 2020
@jmagman
jmagman deleted the module-name-script branch June 24, 2020 23:52
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@jmagman @mingwandroid
Make module run script names unique (flutter#60228)
a3ab3ea
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xster xster Awaiting requested review from xster
1 more reviewer
@christopherfujino christopherfujino christopherfujino approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: existing-apps Integration with existing apps via the add-to-app flow c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

5 participants

@jmagman @flutter-github-sync @christopherfujino @googlebot @fluttergithubbot