Skip to content

InteractiveViewer scroll direction - #60523

Merged
fluttergithubbot merged 3 commits into
flutter:masterfrom
justinmc:iv-scroll-direction
Jun 30, 2020
Merged

fluttergithubbot merged 3 commits into
flutter:masterfrom
justinmc:iv-scroll-direction

Conversation

@justinmc

Copy link
Copy Markdown
Contributor

Description

This PR aligns InteractiveViewer's zoom behavior with Google Maps and most other scroll zooming.

CC @not-holar.

Related Issues

Mentioned at #56409 (comment)

Tests

I added the following tests:

  • I reversed the direction of the existing scroll zooming test.

Breaking Change

This is a niche behavior change, but it shouldn't break any external tests.

@justinmc
justinmc requested a review from LongCatIsLooong June 29, 2020 15:28
@justinmc justinmc self-assigned this Jun 29, 2020
@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Jun 29, 2020
@fluttergithubbot
fluttergithubbot merged commit 8ab513a into flutter:master Jun 30, 2020
@justinmc
justinmc deleted the iv-scroll-direction branch June 30, 2020 23:34
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants