Repository navigation
Renamed ContainedButton et al. to ElevatedButton et al. - #61262
Merged
HansMuller merged 5 commits intoJul 11, 2020
Merged
HansMuller merged 5 commits into
HansMuller merged 5 commits into
Conversation
fluttergithubbot
added
p: material_ui
This was referenced Jul 10, 2020
Merged
darrenaustin
approved these changes
Jul 10, 2020
darrenaustin
left a comment
darrenaustin
left a comment
Contributor
There was a problem hiding this comment.
Minor wording change, but LGTM.
|
|
||
| @Deprecated( | ||
| 'This class was briefly released with the wrong name. The correct name is ElevatedButton. ' | ||
| 'This class was deprecated after within 24 hours of its debut' |
Contributor
There was a problem hiding this comment.
'was deprecated after 24 hours of its debut '
added 2 commits
July 10, 2020 14:45
| /// Please use [ElevatedButtonTheme]. | ||
| @Deprecated( | ||
| 'This class was briefly released with the wrong name. ' | ||
| 'The correct name is ContainedButtonThemeData. ' |
Contributor
There was a problem hiding this comment.
Shouldn't this be ElevatedButtonThemeData?
Contributor
Author
There was a problem hiding this comment.
Yes, you're correct, thanks for pointing that out.
Contributor
|
In /lib/src/material/elevated_button_theme.dart, line 133 has the wrong name. https://github.com/flutter/flutter/pull/61262/files#r453116191 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "New Button Universe" PR, #59702, landed less than 24 hours ago. We've just been informed by Material Design spec developers that they'd really prefer to call
ContainedButtonElevatedButton. In fact, when an updated Material Design spec is published, the official name will have been changed.Since the ContainedButton class is so new, and because "ElevatedButton" is a little closer to the original "RaisedButton" name, we're going to quickly rename ContainedButton to be ElevatedButton now, and deprecate the old class names. The old classes still exist, but should be gone within a week.
I apologize for the confusion.