Skip to content

[flutter_tools] turn down flutter generate - #61475

Merged
jonahwilliams merged 2 commits into
flutter:masterfrom
jonahwilliams:remove_flutter_generate
Jul 16, 2020
Merged

jonahwilliams merged 2 commits into
flutter:masterfrom
jonahwilliams:remove_flutter_generate

Conversation

@jonahwilliams

@jonahwilliams jonahwilliams commented Jul 14, 2020 •

Copy link
Copy Markdown
Contributor

Description

complete removal of all generate functionality

Fixes #61508

@fluttergithubbot fluttergithubbot added tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Jul 14, 2020
@jonahwilliams
jonahwilliams marked this pull request as ready for review July 15, 2020 20:07
@christopherfujino

Copy link
Copy Markdown
Contributor

The code change looks good to me. Can we delete this command in one commit, though? I'm thinking of both of internal implementations and external users using the command in their workflow.

@jonahwilliams

Copy link
Copy Markdown
Contributor Author

There should be no google3 implications as it is unused. I did land the deprecation earlier #58328 which should be in the next stable

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams
jonahwilliams merged commit 045f3a5 into flutter:master Jul 16, 2020
@jonahwilliams
jonahwilliams deleted the remove_flutter_generate branch July 16, 2020 16:51
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
complete removal of all generate functionality

Fixes flutter#61508
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
complete removal of all generate functionality

Fixes flutter#61508
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate and remove flutter generate functionality

4 participants