Repository navigation
[flutter_tools] add feature for iOS, android, and fuchsia - #61481
Merged
jonahwilliams merged 7 commits intoJul 16, 2020
Merged
Conversation
fluttergithubbot
added
tool
…ms/flutter into android_ios_fuchsia_features
jmagman
approved these changes
Jul 15, 2020
jmagman
left a comment
jmagman
left a comment
Member
There was a problem hiding this comment.
After updating the g3 rollers, the fuchsia feature will be turned off by default.
I'm guessing this PR has to roll, then you'll immediately update to make fuchsia off? Definitely don't want our users to start by default caching fuchsia artifacts.
|
|
||
| /// Whether fast single widget reloads are enabled. | ||
| bool get isSingleWidgetReloadEnabled => isEnabled(singleWidgetReload); | ||
| bool get isSingleWidgetReloadEnabled => false; |
Member
There was a problem hiding this comment.
Want to put this one at the end of the list after the platforms? I thought for a second you edited this accidentally.
| import '../base/platform.dart'; | ||
| import '../cache.dart'; | ||
| import '../features.dart'; | ||
| import '../globals.dart' as globals; |
| import '../base/context.dart'; | ||
| import '../base/platform.dart'; | ||
| import '../doctor.dart'; | ||
| import '../globals.dart' as globals; |
|
|
||
| import '../base/platform.dart'; | ||
| import '../doctor.dart'; | ||
| import '../globals.dart' as globals; |
Contributor
Author
Not quite - we still won't download fuchsia artifacts by default if precache is called, only android and iOS have that behavior. The feature is also disabled on dev, beta, stable channels so it isn't exposed any more than it was before |
Member
|
Contributor
Author
|
noooooo |
added 2 commits
July 15, 2020 17:24
Pragya007
pushed a commit
to Pragya007/flutter
that referenced
this pull request
Aug 11, 2020
) Add feature flags for android, ios, and fuchsia (on by default). After updating the g3 rollers, the fuchsia feature will be turned off by default. Creates a simpler base type of feature flags for g3 to extend. Updates android, ios, fuchsia workflows to use feature flags check. Removes concept of stable artifacts and checks on flutter version. Fixes flutter#58999 flutter#52859 flutter#12768
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
) Add feature flags for android, ios, and fuchsia (on by default). After updating the g3 rollers, the fuchsia feature will be turned off by default. Creates a simpler base type of feature flags for g3 to extend. Updates android, ios, fuchsia workflows to use feature flags check. Removes concept of stable artifacts and checks on flutter version. Fixes flutter#58999 flutter#52859 flutter#12768
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add feature flags for android, ios, and fuchsia (on by default). After updating the g3 rollers, the fuchsia feature will be turned off by default. Creates a simpler base type of feature flags for g3 to extend.
Updates android, ios, fuchsia workflows to use feature flags check.
Removes concept of stable artifacts and checks on flutter version.
Fixes #58999
#52859
#12768