Skip to content

[Material] Updated icons and fonts - #61778

Merged
fluttergithubbot merged 17 commits into
flutter:masterfrom
willlarche:icon-update
Jul 24, 2020
Merged

[Material] Updated icons and fonts#61778
fluttergithubbot merged 17 commits into
flutter:masterfrom
willlarche:icon-update

Conversation

@willlarche

@willlarche willlarche commented Jul 18, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Additional icons, new icon styles (outline, rounded, sharp), and the latest Roboto and RobotoCondensed fonts. update_icons.dart has been updated for additional names and to prevent regressions.

Icon tree shaking has landed for iOS and Android (#56633). There is no icon tree shaking on web (#57181) so there will be an increase in bundle size for that platform.

NOTE: The fonts repo has changed a bit. The wiki on updating material fonts needs to be updated as well as the go link for the internal hosting of the icons font which is now being custom made for us by the Google Fonts team. (Thank you!)

Screen Shot 2020-07-17 at 11 35 31 PM

Screen Shot 2020-07-17 at 11 35 12 PM

Screen Shot 2020-07-17 at 11 35 56 PM

Screen Shot 2020-07-17 at 11 36 14 PM

Related Issues

fixes #52713
fixes #43747
fixes #31665
fixes #61777
fixes #27956
fixes #18384
fixes #49014

Tests

I added the following tests:

update_icons.dart has a function checking that the new codepoints are a superset of the old ones.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • [X ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [X ] I signed the CLA.
  • [ X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • [X ] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@fluttergithubbot fluttergithubbot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 18, 2020
@fluttergithubbot

fluttergithubbot commented Jul 18, 2020

Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

JoseAlba
JoseAlba approved these changes Jul 20, 2020
View reviewed changes

@JoseAlba JoseAlba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

██╗      ██████╗ ████████╗███╗   ███╗
██║     ██╔════╝ ╚══██╔══╝████╗ ████║
██║     ██║  ███╗   ██║   ██╔████╔██║
██║     ██║   ██║   ██║   ██║╚██╔╝██║
███████╗╚██████╔╝   ██║   ██║ ╚═╝ ██║
╚══════╝ ╚═════╝    ╚═╝   ╚═╝     ╚═╝

rami-a
rami-a approved these changes Jul 20, 2020
View reviewed changes

@rami-a rami-a left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nits.

Comment thread dev/tools/update_icons.dart Outdated
Comment thread dev/tools/update_icons.dart Outdated
Comment thread dev/tools/update_icons.dart Outdated
Comment thread dev/tools/update_icons.dart Outdated
Comment thread dev/tools/update_icons.dart Outdated
Comment thread dev/tools/update_icons.dart Outdated
Comment thread dev/tools/update_icons.dart Outdated
Comment thread dev/tools/update_icons.dart Outdated
@willlarche

willlarche commented Jul 20, 2020

Copy link
Copy Markdown
Contributor Author

Having conversation around TTF/OTF. Do not merge yet.

@willlarche
willlarche requested review from HansMuller and dnfield July 22, 2020 02:55
dnfield
dnfield approved these changes Jul 22, 2020
View reviewed changes

@dnfield dnfield left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

HansMuller
HansMuller approved these changes Jul 23, 2020
View reviewed changes

@HansMuller HansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread dev/tools/update_icons.dart
@fluttergithubbot
fluttergithubbot merged commit 7782845 into flutter:master Jul 24, 2020
@jesusrp98

jesusrp98 commented Jul 25, 2020 •
edited
Loading

Copy link
Copy Markdown

@willlarche what about the two-tone icon style? Is it implemented in this PR?

Also, great work to all? Such a needed feature 🤩

@willlarche

willlarche commented Jul 25, 2020

Copy link
Copy Markdown
Contributor Author

Thanks @jessusrp98 ! Unfortunately the font we use for icons can only display 1 color. Two tone fonts have be imported as an image.

@jesusrp98

jesusrp98 commented Jul 25, 2020

Copy link
Copy Markdown

Oh, I see. So does it mean that there are no further plans to implement that style as an option in the future?

Thanks!

@willlarche
willlarche deleted the icon-update branch July 25, 2020 15:06
@tvolkert

tvolkert commented Jul 25, 2020

Copy link
Copy Markdown
Contributor

The wiki on updating material fonts needs to be updated

@willlarche did you make that update as well?

@rsheeter

rsheeter commented Jul 25, 2020

Copy link
Copy Markdown

Re two-tone, I'd love to see it happen. Operating system and web browser support for color fonts has historically been a problem for color but this has improved somewhat lately; https://www.colorfonts.wtf/#section3.

Off the top of my head, to support twotone in Flutter we would need to:

  • Confirm COLR (best UA support, we can compile two-tone to this format) works on all the environments Fluter supports
  • Confirm hb-subset supports COLR and CPAL; implement these tables if not (my team can take care of that if necessary)
  • Contemplate whether users should be able to override the color palette beyond just setting foreground color

There are doubtless additional issues.

@willlarche

willlarche commented Jul 26, 2020

Copy link
Copy Markdown
Contributor Author

@tvolkert Thanks for reminding me. Done!

@dragonblood

dragonblood commented Aug 3, 2020

Copy link
Copy Markdown

so if I want to use rounded add_circle, how can i do that?

icon: Icon(Icons.add_circle)
this still displays filled icons

@willlarche

willlarche commented Aug 3, 2020 via email

Copy link
Copy Markdown
Contributor Author

Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
@willlarche @Pragya007
[Material] Updated icons and fonts (flutter#61778)
0e653be
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@willlarche @mingwandroid
[Material] Updated icons and fonts (flutter#61778)
3b4a5a0
This was referenced Sep 24, 2020
Closed
Merged
Closed
abc873693 added a commit to nsysu-code-club/ap_common that referenced this pull request Oct 5, 2020
@abc873693
Remove outline_material_icons package
4dc849f 
Because flutter 1.22 support outlined icons for flutter/flutter#61778
This was referenced Oct 26, 2020
Closed
Merged
@guidezpl guidezpl mentioned this pull request Jan 5, 2021
Closed
@geekydiamond geekydiamond mentioned this pull request Feb 8, 2021
Closed
@kenthinson kenthinson mentioned this pull request May 12, 2021
Closed
@JacobRoe JacobRoe mentioned this pull request May 21, 2021
Merged
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers
@HansMuller HansMuller HansMuller approved these changes
@rami-a rami-a rami-a approved these changes
@dnfield dnfield dnfield approved these changes
@JoseAlba JoseAlba JoseAlba approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone